Fix clearing the inverse relation when has_many_inversing is enabled #42729
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casperisfine
force-pushed
the
fix-has-many-inversing-remove
branch
from
51bf22b
to
ce0cde1
Compare
p8
reviewed
Jul 8, 2021
| with_has_many_inversing do | ||
| book = Book.create! | ||
| citation = book.citations.create! | ||
| citation.book = nil |
There was a problem hiding this comment.
Not really, this hard crash on main. But yes, I could add some assertions.
There was a problem hiding this comment.
I think an assertion that the inverse is cleared would be nice, but this PR looks good to me.
There was a problem hiding this comment.
Actually that's not something that was ever supported as far as I can tell, and it seems very hard to support.
I think the fix is just to not do anything on has_many.
casperisfine
force-pushed
the
fix-has-many-inversing-remove
branch
from
ce0cde1
to
2e8f2f7
Compare
rails#42601 fixed clearing the inverse relation, but it didn't account for collection associations. For these, just assigning `nil` isn't possible because we need the record to remove it from the collection. So this PR introduce an explicit method for this purpose rather than reuse `inversed_from(nil)`.
casperisfine
force-pushed
the
fix-has-many-inversing-remove
branch
from
2e8f2f7
to
6d7235d
Compare
|
The sqlite3_mem suite failed for a random reason, other than that it's green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42601 fixed clearing the inverse relation, but it didn't account for collection associations.
For these, just assigning
nilisn't possible because we need the record to remove it from the collection.So this PR introduce an explicit method for this purpose rather than reuse
inversed_from(nil).cc @mdemare @p8